He was graduated from the Faculty of police and the work as an officer, but he joined the Higher Institute of Dramatic Arts and graduated in 1951, he wrote a scenario of some movies. Of the most famous plays "El-Wad Sayed El-Shaghal" and "Witness who saw Nothing" with the star "Adel Imam".The most prominent movies he shared in : ((The second man) in 1959, (The Black Candles) in 1962 (El-Naser Salah El-din) in 1963, (Marrying In The Modern Way) in 1968, (The Hot Tears) in 1976, (Love In The Prison) in 1983, (Love Above The plateau the pyramid) in 1986.